-
Notifications
You must be signed in to change notification settings - Fork 4
January release notes for developer framework #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@mehdi0501 and @cachafla I have resolved your comments and updated the root comment with the latest output. Could you take another look and let me know if the release notes are ready? (We probably need to update the release date again but I will wait until the release notes are otherwise ready.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me, thank you for addressing the comments around explanations of the new dev framework features!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great 👏
OK, updated the notebooks one last time and sanity checked that the rendered static site works as expected. Done, merging. |
Internal Notes for Reviewers
This PR includes:
Open items:
Looks like we might have a couple of new tests without release notes?
[SC-8240] Add warning message for unregistered tests in template validmind-library#316 did a really nice job cleaning up our notebooks, but we need to figure out how to sweat more of the details. E.g. this new notebook that gets linked to from the release notes has some clearly unfinished stuff right at the top that both the original author and reviewer missed:
Output
External Release Notes