Skip to content

Remove safe external dependencies #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Conversation

nrichers
Copy link
Collaborator

@nrichers nrichers commented Nov 17, 2023

Internal Notes for Reviewers

This is a companion PR to #146 that removes only those external dependencies that are safe to remove. It does this by:

  • Locally storing fonts and updating how we import these fonts
  • Removing other, unneeded external font references in our template schema docs

This PR should be merged as it reduces our dependencies and improves site loading times, as we no longer need to fetch our main font from Google every time we load the site.

There are no output changes to review, as the site largely looks almost exactly the same, except for the template schema docs that now use the same font as the rest of our docs site.

External Release Notes

To improve loading times and reduce the reliance on being connected to the internet, we removed some external dependencies for our docs site:

  • Fonts are now stored and imported locally
  • Other font references in our template schema docs have been removed

@nrichers nrichers added documentation Improvements or additions to documentation internal Not to be externalized in the release notes labels Nov 17, 2023
@nrichers nrichers requested a review from mehdi0501 November 17, 2023 14:18
@nrichers nrichers merged commit 48dfc4d into main Nov 22, 2023
@nrichers nrichers deleted the remove-safe-external-dependencies branch November 22, 2023 21:36
@nrichers nrichers removed the internal Not to be externalized in the release notes label Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants