Skip to content

Add links to validmind.ai #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 17, 2023
Merged

Add links to validmind.ai #140

merged 5 commits into from
Oct 17, 2023

Conversation

nrichers
Copy link
Collaborator

Internal Notes for Reviewers

This PR adds links to validmind.ai to top navigation and footer for our docs site:

Top navigation:

image

Footer:

image

External Release Notes

@nrichers nrichers added the internal Not to be externalized in the release notes label Oct 17, 2023
Copy link
Collaborator

@gtagle gtagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a few mentions of "Main Site", commented on some of them but not all.

@@ -534,6 +536,9 @@ <h2 style="color: var(--bs-white);" class="anchored">Support &amp; Training</h2>
<div class="nav-footer-right">
<ul class="footer-items list-unstyled">
<li class="nav-item">
<a class="nav-link" href="https://validmind.com/">Main Site <i class="fa-solid fa-external-link" aria-label="external-link"></i></a>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not too sure, but should this also be "validmind.ai" ?

@@ -159,8 +159,28 @@
<a class="nav-link" href="../../guide/support.html" rel="" target="">
<span class="menu-text">Support</span></a>
</li>
<li class="nav-item">
<a class="nav-link" href="https://validmind.com/" rel="" target="_blank">
<span class="menu-text">Main Site <i class="fa-solid fa-external-link" aria-label="external-link"></i></span></a>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also be "validmind.ai" ?

<ul class="dropdown-menu dropdown-menu-end" aria-labelledby="quarto-navigation-tool-dropdown-0">
<li>
<a class="dropdown-item quarto-navbar-tools ms-auto-item" href="https://validmind.com/">
Main Site {{&lt; fa external-link &gt;}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also be "validmind.ai" ?

@@ -689,6 +707,9 @@ <h1 class="title">Enhancements – September 26, 2023</h1>
<div class="nav-footer-right">
<ul class="footer-items list-unstyled">
<li class="nav-item">
<a class="nav-link" href="https://validmind.com/">Main Site <i class="fa-solid fa-external-link" aria-label="external-link"></i></a>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also be "validmind.ai" ?

@nrichers
Copy link
Collaborator Author

nrichers commented Oct 17, 2023

Ah, I forgot to re-render the docs site after my last change, fixed. There should be no references to "Main Site" in our docs site now:

image

Copy link
Collaborator

@gtagle gtagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@nrichers nrichers merged commit 711d154 into main Oct 17, 2023
@nrichers nrichers deleted the docs-site-fixes branch October 17, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Not to be externalized in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants