Skip to content

Add PR link to highlights file #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Conversation

sydneysugar
Copy link
Contributor

Internal Notes for Reviewers

Updated script to add the additional PR information as a comment to the generated release highlights file. Also updated formatting of this file to match the other general label files.

Before:
Screenshot 2023-07-31 at 10 22 48 AM

After:
Screenshot 2023-07-31 at 10 20 31 AM

External Release Notes

@sydneysugar sydneysugar added the internal Not to be externalized in the release notes label Jul 31, 2023
@sydneysugar sydneysugar requested a review from nrichers July 31, 2023 17:23
Copy link
Collaborator

@nrichers nrichers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled down your PR and tested it locally. Works nicely! :shipit:

@nrichers nrichers added the infrastructure Docs infra changes label Jul 31, 2023
@sydneysugar sydneysugar merged commit 6719107 into main Jul 31, 2023
@sydneysugar sydneysugar deleted the update-release-notes-script branch July 31, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Docs infra changes internal Not to be externalized in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants