Skip to content

Python release notes #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Python release notes #120

wants to merge 3 commits into from

Conversation

p-m-s-f
Copy link
Contributor

@p-m-s-f p-m-s-f commented Jul 19, 2023

Internal Notes for Reviewers

Responding to this story.

This script is meant to generate release notes based on PRs in the validmind-python repo. While the script doesn't return any errors, at present it doesn't properly generate release notes.

By adding references to the python repo to the gh commands, the script accesses the python repo instead of the docs repo. However, this won't work unless you have a version of the python repo downloaded locally. Additionally, as a side effect of working on a Windows machine, I've had to manually set the encoding to utf-8 throughout the script.

References to documentation in the generate_release_notes script have been replaced with dependencies for the python specific version. This was mainly for testing purposes, as the dependencies tag was the only label attached to any of the 30 previous merged PRs. Previously, references to documentation had been replaced with python.

@p-m-s-f p-m-s-f added enhancement New feature or request help wanted Extra attention is needed internal Not to be externalized in the release notes labels Jul 19, 2023
@p-m-s-f p-m-s-f requested a review from nrichers July 19, 2023 01:47
@nrichers nrichers requested a review from sydneysugar July 20, 2023 16:00
@nrichers
Copy link
Collaborator

This PR has been incorporated into #121, closing. Thank you for all your work on this, @p-m-s-f!

@nrichers nrichers closed this Jul 25, 2023
@nrichers nrichers deleted the python-release-notes branch October 6, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed internal Not to be externalized in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants