Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal Notes for Reviewers
Responding to this story.
This script is meant to generate release notes based on PRs in the validmind-python repo. While the script doesn't return any errors, at present it doesn't properly generate release notes.
By adding references to the python repo to the gh commands, the script accesses the python repo instead of the docs repo. However, this won't work unless you have a version of the python repo downloaded locally. Additionally, as a side effect of working on a Windows machine, I've had to manually set the encoding to utf-8 throughout the script.
References to
documentation
in the generate_release_notes script have been replaced withdependencies
for the python specific version. This was mainly for testing purposes, as thedependencies
tag was the only label attached to any of the 30 previous merged PRs. Previously, references todocumentation
had been replaced withpython
.