Skip to content

Fix typo and remove testing period #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

sydneysugar
Copy link
Contributor

@sydneysugar sydneysugar commented Jul 18, 2023

Internal Notes for Reviewers

Fixed typo in license agreement and removed the testing period and date.

image

External Release Notes

@sydneysugar sydneysugar added documentation Improvements or additions to documentation internal Not to be externalized in the release notes labels Jul 18, 2023
@sydneysugar sydneysugar requested a review from nrichers July 18, 2023 21:44
Copy link
Collaborator

@nrichers nrichers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but @jonasjacobi should also review (only the license-agreement.qmd file which I tagged you in). :shipit:

EDIT: To make it easier for others to review, I added a screenshot of the output with the changed sections highlighted.

@@ -7,7 +7,7 @@ SOFTWARE LICENSE AGREEMENT

IMPORTANT - READ CAREFULLY:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonasjacobi this is the only file you should need to review for the license agreement updates in the docs site.

@sydneysugar sydneysugar requested a review from jonasjacobi July 18, 2023 23:15
@nrichers
Copy link
Collaborator

Replaced by PR #122, closing. Thank you all the same for pushing these changes!

@nrichers nrichers closed this Jul 27, 2023
@nrichers nrichers deleted the fix-license-agreement branch July 27, 2023 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation internal Not to be externalized in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants