Skip to content

User guide updates for adding content blocks #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 23, 2023
Merged

User guide updates for adding content blocks #109

merged 9 commits into from
Jul 23, 2023

Conversation

p-m-s-f
Copy link
Contributor

@p-m-s-f p-m-s-f commented Jun 29, 2023

This PR includes docs for adding content blocks, including a small animated GIF to show how the functionality works:

2023-07-20_00-04-27 (1)

Original PR description from Parris

Responding to this story. I've written a rough draft to hand off to Nik. Currently, this new page is lumped in with the other guides, and doesn't have a reference along the left hand navbar.

I also found and corrected a typo on another page:

image

External Release Notes

You can now add new sections, known as content blocks to documentation projects. This feature enables you to modify your existing documentation projects by directly editing them in the Platform UI. Learn more ...

@github-actions
Copy link
Contributor

Pull requests must include at least one of the required labels: internal, highlight, enhancement, bug, deprecation, documentation. Except for internal, pull requests must also include a description in the release notes section.

@nrichers nrichers self-requested a review July 5, 2023 17:12
@nrichers
Copy link
Collaborator

nrichers commented Jul 5, 2023

Where to add in the docs:

image

@p-m-s-f
Copy link
Contributor Author

p-m-s-f commented Jul 5, 2023

image

here's a comment rod left for me. i'll adjust step 3 to reflect there only being a simple text block. the initial pr will still exist for when test driven blocks are added, so i can come back and reference it when i need to update the docs for that.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

Pull requests must include at least one of the required labels: internal, highlight, enhancement, bug, deprecation, documentation. Except for internal, pull requests must also include a description in the release notes section.

@p-m-s-f
Copy link
Contributor Author

p-m-s-f commented Jul 5, 2023

image

here's the new docs page. i've edited step 3 as per rod's comment, and i added the page to the left navbar under Document Models with the Validmind UI.

pinging @nrichers for review

@p-m-s-f p-m-s-f added the documentation Improvements or additions to documentation label Jul 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

Pull requests must include a description in the release notes section.

Copy link
Collaborator

@nrichers nrichers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another great docs PR from you, @p-m-s-f! I had some minor comments and will approve once the extraneous files are removed. Let me know what you think about creating an animated GIF, I'm happy to go with your judgement on this.

@github-actions
Copy link
Contributor

Pull requests must include a description in the release notes section.

@nrichers nrichers added the enhancement New feature or request label Jul 19, 2023
@github-actions
Copy link
Contributor

Pull requests must include a description in the release notes section.

@nrichers nrichers requested a review from cachafla July 20, 2023 07:07
Copy link
Collaborator

@nrichers nrichers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I reworked Parris' original PR to include more conceptual info, more detailed steps after testing, and an animated GIF. Ready for @cachafla to review.

@nrichers nrichers changed the title new docs page for inserting a block User guide updates for adding content blocks Jul 20, 2023
Copy link
Contributor

@cachafla cachafla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. @nrichers we can push the "test driven" blocks documentation on a separate PR unless you want to publish those two at the same time.

In terms of the GIFs with weird capitalization (Simple text Block), we will re-deploy to dev later today once we have some cosmetic fixes finalized (cc @gtagle).

@nrichers
Copy link
Collaborator

we can push the "test driven" blocks documentation on a separate PR unless you want to publish those two at the same time

@cachafla I had included some basic info for test driven blocks was I thought they would not be released this time around? If they will be, I can update this PR with some more info.

I can also update the animated GIF after the latest UI changes go in.

Copy link
Collaborator

@nrichers nrichers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added content for test-driven blocks after testing in the UI, made some text improvements, and updated the animated GIF for now.

@nrichers nrichers merged commit a196ccf into main Jul 23, 2023
@nrichers nrichers deleted the test-block-doc branch July 23, 2023 19:49
sydneysugar pushed a commit that referenced this pull request Jul 24, 2023
* docs page for adding content block

* edited step 3 & added to left navbar

* Expand topic with more info, add animated GIF

* Remove markdowntest file

* Remove comment from source

* Add steps for test-driven content blocks, interim GIF update

* Text edit

* Text edit

---------

Co-authored-by: Nik Richers <nik@validmind.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants