Skip to content

Docs site rework for template functionality #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 22, 2023
Merged

Docs site rework for template functionality #102

merged 5 commits into from
Jun 22, 2023

Conversation

nrichers
Copy link
Collaborator

@nrichers nrichers commented Jun 20, 2023 •
edited by sydneysugar
Loading

Internal Notes for Reviewers

This PR includes changes for https://app.shortcut.com/validmind/story/1741/docs-for-add-custom-tests-feature.

WIP — NOT READY FOR REVIEW

External Release Notes

Test description 10 for documentation and highlight labels.

@nrichers nrichers added documentation Improvements or additions to documentation highlight Feature to be curated in the release notes labels Jun 20, 2023
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #1741: Docs for add custom tests feature.

@nrichers nrichers marked this pull request as draft June 20, 2023 23:33
cachafla
cachafla reviewed Jun 21, 2023
View reviewed changes
@nrichers nrichers marked this pull request as ready for review June 22, 2023 04:23
cachafla
cachafla approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@cachafla cachafla left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We just need to update these references:

          - text: "Run a template"
          - text: "Integrate a custom test provider"
          - notebooks/how_to/implementing_custom_tests.ipynb

@nrichers nrichers merged commit f5aecf3 into main Jun 22, 2023
@nrichers nrichers deleted the nrichers/sc-1741/docs-for-add-custom-tests-feature branch June 22, 2023 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cachafla cachafla cachafla approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation highlight Feature to be curated in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nrichers @cachafla