Domain specific email validation flag #873
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#832 added additional validation for gmail addresses:
_
Example of gmail rejecting a short username:
Unfortunately this has caused some confusion upstream where test fixtures would use a syntactically valid email like
test@gmail.com
only to have it fail validation.This PR updates the validator to skip domain specific validation unless a new
domain_specific_validation
flag is set. The flag is disabled by default.This fixes #853 and #865