Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain specific email validation flag #873

Merged
merged 1 commit into from
Jul 31, 2018

Conversation

chriso
Copy link
Collaborator

@chriso chriso commented Jul 31, 2018

#832 added additional validation for gmail addresses:

  • certain characters are not allowed, for example _
  • the user part must be 6 to 30 chars inclusive

Example of gmail rejecting a short username:

40112348-0e30bb06-5949-11e8-9f58-49aadd5eb670

Unfortunately this has caused some confusion upstream where test fixtures would use a syntactically valid email like test@gmail.com only to have it fail validation.

This PR updates the validator to skip domain specific validation unless a new domain_specific_validation flag is set. The flag is disabled by default.

This fixes #853 and #865

@chriso chriso merged commit e027403 into master Jul 31, 2018
@chriso chriso deleted the chriso/domain-specific-validation-flag branch July 31, 2018 05:59
@patelnav
Copy link

patelnav commented Aug 3, 2018

Loving how responsive and quick you guys are with updates. Awesome job 👌🏾

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

isEmail should check specific gmail case only under option
2 participants