Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added Danish mobile phone checking local: da-DK #538

Merged
merged 3 commits into from
Jun 3, 2016
Merged

added Danish mobile phone checking local: da-DK #538

merged 3 commits into from
Jun 3, 2016

Conversation

itree
Copy link
Contributor

@itree itree commented Jun 2, 2016

Just added Danish local support

@coveralls
Copy link

coveralls commented Jun 2, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 99.091% when pulling 756377c on itree:master into d3e38cf on chriso:master.

@chriso
Copy link
Collaborator

chriso commented Jun 2, 2016

Can you fix the syntax error and also update the README?

@itree
Copy link
Contributor Author

itree commented Jun 3, 2016

Ah I see. Just did that on forked branch. Should I request another pull request?

@coveralls
Copy link

coveralls commented Jun 3, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 99.091% when pulling ce5373f on itree:master into d3e38cf on chriso:master.

@chriso
Copy link
Collaborator

chriso commented Jun 3, 2016

No need for another pull request. I can see the commit here.

It looks like you've updated the README entry for isAlphanumeric() rather than isMobilePhone(). Could you fix that up?

@itree
Copy link
Contributor Author

itree commented Jun 3, 2016

Thanks. Done!

@coveralls
Copy link

coveralls commented Jun 3, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 99.091% when pulling fa8c016 on itree:master into d3e38cf on chriso:master.

@chriso
Copy link
Collaborator

chriso commented Jun 3, 2016

Thanks.

@chriso chriso merged commit 11bdf94 into validatorjs:master Jun 3, 2016
chriso added a commit that referenced this pull request Jun 3, 2016
@chriso
Additional stuff for #538
3c9b751
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@itree @coveralls @chriso