fixed issue #2432 #2437
Merged
fixed issue #2432 #2437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
could you also add tests for this specific scenario |
|
In which file should I add them? I wasn't sure of that |
|
added few tests for this issue in validators.test.js |
rubiin
approved these changes
Aug 10, 2024
rubiin
requested changes
Aug 10, 2024
|
yep, am on it rn |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2437 +/- ##
===========================================
- Coverage 100.00% 99.96% -0.04%
===========================================
Files 110 111 +1
Lines 2510 2517 +7
Branches 633 634 +1
===========================================
+ Hits 2510 2516 +6
- Partials 0 1 +1 ☔ View full report in Codecov by Sentry. |
|
Done, i put the test in the wrong area, please check now |
rubiin
approved these changes
Aug 10, 2024
profnandaa
approved these changes
Aug 15, 2024
|
Thanks for your contrib! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
an email of the type "example*@gmail.com was accepted due to an errant if statement in isEmail.js file which was only checking for the first double quote (user[0] === '"'). Fixed it by adding a secondary "and" condition along with it, to ensure the local part is completely enclosed in the double quotes (&& user[user.length - 1] === '"').
Checklist