feat(isMobilePhone): Added regex for New Caledonia #2388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2388 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 107 107
Lines 2449 2449
Branches 619 619
=========================================
Hits 2449 2449 ☔ View full report in Codecov by Sentry. |
profnandaa
requested changes
Apr 27, 2024
| @@ -104,6 +104,7 @@ const phones = { | |||
| 'fr-GF': /^(\+?594|0|00594)[67]\d{8}$/, | |||
| 'fr-GP': /^(\+?590|0|00590)[67]\d{8}$/, | |||
| 'fr-MQ': /^(\+?596|0|00596)[67]\d{8}$/, | |||
| 'fr-NC': /^(\+?687)(75|76|77|78|79|80|81|82|83|84|85|86|87|89|90|91|92|93|94|95|96|97|98|99)\d{4}$/, | |||
There was a problem hiding this comment.
nit: this regex can be simplified: /^(\+?687)(7[5-9]|8[0-9]|9[0-9])\d{4}$/
|
Thanks for your contribution! 🎉 |
profnandaa
added
🎉 first-pr
🧹 needs-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a regex for New Caledonia, based on the ITU document here: