Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update isMobilePhone.js - added Belize es-BZ #2063

Closed
wants to merge 2 commits into from

Conversation

emday4prez
Copy link

added Belize es-BZ. Country code 501, first digit after country code cannot be 0,1, or 9. After country code and first digit any digit combination of length=6.

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

added Belize es-BZ. Country code 501,  first digit after country code cannot be 0,1, or 9. After country code and first digit any digit combination of length=6.
@codecov
Copy link

codecov bot commented Oct 9, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (4a57ca0) compared to base (86a07ba).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2063   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          104       104           
  Lines         2203      2203           
  Branches       477       477           
=========================================
  Hits          2203      2203           
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sauravpratihar
Copy link

@emday4prez - Thanks for adding this PR. Wondering why this PR is not yet merged?

Copy link
Member

@rubiin rubiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests as well

Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And as pointed out; also add tests

src/lib/isMobilePhone.js Outdated Show resolved Hide resolved
Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com>
@emday4prez emday4prez closed this Aug 28, 2024
@emday4prez emday4prez deleted the patch-1 branch August 28, 2024 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants