Skip to content

fix(isBIC): add XK to accepted BIC country codes #2046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 2, 2023
Merged

fix(isBIC): add XK to accepted BIC country codes #2046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
41ae543
fix(isBIC): add `XK` to accepted BIC country codes
ejcheng Sep 20, 2022
7be6ba1
chore: change 'XK' string to use single quotes
ejcheng Sep 20, 2022
debdd81
refactor: country code to separate variable
ejcheng Sep 20, 2022
4900b34
chore: fix linting issues
ejcheng Sep 20, 2022
337321e
chore: move `toUpperCase` comment
ejcheng Sep 21, 2022
cddd9e5
Merge branch 'validatorjs:master' into xk-country-code
ejcheng Jan 31, 2023
6df1853
test: add `XK` BIC tests
ejcheng Jan 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/lib/isBIC.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@ export default function isBIC(str) {

// toUpperCase() should be removed when a new major version goes out that changes
// the regex to [A-Z] (per the spec).
if (!CountryCodes.has(str.slice(4, 6).toUpperCase())) {
const countryCode = str.slice(4, 6).toUpperCase();

if (!CountryCodes.has(countryCode) && countryCode !== 'XK') {
return false;
}

Expand Down
2 changes: 2 additions & 0 deletions test/validators.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5075,6 +5075,7 @@ describe('Validators', () => {
'SBICKEN1',
'SBICKENY',
'SBICKEN1YYP',
'SBICXKN1YYP',
],
invalid: [
'SBIC23NXXX',
Expand All @@ -5083,6 +5084,7 @@ describe('Validators', () => {
'SBICKENXX9',
'SBICKEN13458',
'SBICKEN',
'SBICXK',
],
});
});
Expand Down