Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regex for Mexico passport numbers #1998

Merged
merged 1 commit into from
Jul 17, 2022

Conversation

samilieberman
Copy link
Contributor

Updated isPassportNumber to include regex for Mexico passport numbers

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

Screen Shot 2022-07-05 at 7 31 47 PM

@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #1998 (f219330) into master (6fb8bb5) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #1998   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          103       103           
  Lines         2099      2099           
  Branches       474       474           
=========================================
  Hits          2099      2099           
Impacted Files Coverage Δ
src/lib/isPassportNumber.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fb8bb5...f219330. Read the comment docs.

@samilieberman
Copy link
Contributor Author

@profnandaa - this is my first PR to your repo. Please let me know if anything else is required!

@WikiRik
Copy link
Member

WikiRik commented Jul 6, 2022

From the PRs I've seen in the past, this should be fine. It would be nice if you could provide a source to your regex that can be checked in order to make the review process easier

@samilieberman
Copy link
Contributor Author

From the PRs I've seen in the past, this should be fine. It would be nice if you could provide a source to your regex that can be checked in order to make the review process easier

The source is https://community.zscaler.com/t/international-passport-numbers-regex/12433 and i crossed verified other countries with this list to be sure it is accurate.

@samilieberman
Copy link
Contributor Author

samilieberman commented Jul 12, 2022

@profnandaa @tux-tn @WikiRik Can you please review this PR?

@rubiin rubiin merged commit d5f8015 into validatorjs:master Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants