feat(isPhoneNumber): Add isPhoneNumber validator and tests#1917
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1917 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 102 103 +1
Lines 2072 2079 +7
Branches 472 473 +1
=========================================
+ Hits 2072 2079 +7
Continue to review full report at Codecov.
|
Member
Author
|
Thanks for the feedback. I will start looking into that. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add isPhoneNumber validator in reference to issue #1915.
Create isPhoneNumber.js, and add it to index.js, README.md, and write tests in validators.js.
This is one of my first pull requests so I am still unsure as to what do when it comes to all this. I saw the issue and it seemed like something I could do, so I tried to add a basic implementation. I hope I did not step on anyones toes by taking up this issue. If there are any issues or problems please let me know and I will get on it. Any criticisms appreciated.
Checklist