Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(isLat, isLong) #1830: implemented isLat and iLong #1863

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fkrafi
Copy link

@fkrafi fkrafi commented Nov 9, 2021

isLat(str [, options]) | check if the string is a valid latitude coordinate in the format lat.

options is an object that defaults to { checkDMS: false }. Pass checkDMS as true to validate DMS(degrees, minutes, and seconds) latitude format.

isLong(str [, options]) | check if the string is a valid longitude coordinate in the format long.

options is an object that defaults to { checkDMS: false }. Pass checkDMS as true to validate DMS(degrees, minutes, and seconds) longitude format.

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #1863 (50f2eb0) into master (47ee5ad) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1863   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          102       104    +2     
  Lines         2059      2072   +13     
  Branches       464       464           
=========================================
+ Hits          2059      2072   +13     
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (ø)
src/lib/isLat.js 100.00% <100.00%> (ø)
src/lib/isLatLong.js 100.00% <100.00%> (ø)
src/lib/isLong.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47ee5ad...50f2eb0. Read the comment docs.

@fkrafi
Copy link
Author

fkrafi commented Nov 9, 2021

@fncolon can you please accept this PR #1830

@fkrafi
Copy link
Author

fkrafi commented Nov 10, 2021

@profnandaa, @tux-tn, @ezkemboi, can you please have a look

@tux-tn
Copy link
Member

tux-tn commented Nov 15, 2021

Thank you for your PR, i'm wondering if this new validator/feature is needed since we already have isLatLong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants