feat(isLat, isLong) #1830: implemented isLat and iLong #1863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1863 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 102 104 +2
Lines 2059 2072 +13
Branches 464 464
=========================================
+ Hits 2059 2072 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@profnandaa, @tux-tn, @ezkemboi, can you please have a look |
|
Thank you for your PR, i'm wondering if this new validator/feature is needed since we already have |
|
In #1830 we decided that we will not accept a new validator for this, but we can add options to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isLat(str [, options]) | check if the string is a valid latitude coordinate in the format
lat.optionsis an object that defaults to{ checkDMS: false }. PasscheckDMSastrueto validate DMS(degrees, minutes, and seconds) latitude format.isLong(str [, options]) | check if the string is a valid longitude coordinate in the format
long.optionsis an object that defaults to{ checkDMS: false }. PasscheckDMSastrueto validate DMS(degrees, minutes, and seconds) longitude format.Checklist