-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validator Class Added with Builder Pattern #1749
base: master
Are you sure you want to change the base?
Validator Class Added with Builder Pattern #1749
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1749 +/- ##
===========================================
- Coverage 100.00% 96.71% -3.29%
===========================================
Files 102 104 +2
Lines 2015 2103 +88
Branches 454 470 +16
===========================================
+ Hits 2015 2034 +19
- Misses 0 69 +69
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @SankalpaFernando
Thank you for your PR! Is it a work in progress?
@tux-tn The validators need to be added. I'll add them in a future PR |
We still need tests here. |
Created a new file called index.js in the ./lib directory and put all the validator exporting in that file. Meantime, a separate test file was created to test the validator class. |
I'm not sure we want to move or add a builder/chaining pattern to the library. |
Validator Class Added (For Function Chaining)
Added a Validator Class that using the builder pattern to validate the data using chained validation functions
Checklist