Skip to content

chore: update pull_request_template.md#1699

Merged
profnandaa merged 1 commit into
validatorjs:masterfrom
fedeci:patch-1
Jul 19, 2021
Merged

chore: update pull_request_template.md#1699
profnandaa merged 1 commit into
validatorjs:masterfrom
fedeci:patch-1

Conversation

@fedeci

@fedeci fedeci commented Jul 18, 2021

Copy link
Copy Markdown
Contributor

I made the "briefly describe what you have done in this PR" comment that many people, among which me, forget to delete.

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov

codecov Bot commented Jul 18, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1699 (a0648e3) into master (f5f4fcd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1699   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          101       101           
  Lines         2005      2005           
  Branches       452       452           
=========================================
  Hits          2005      2005           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5f4fcd...a0648e3. Read the comment docs.

@profnandaa profnandaa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@profnandaa profnandaa merged commit 8c4b3b3 into validatorjs:master Jul 19, 2021
@fedeci fedeci deleted the patch-1 branch July 19, 2021 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants