-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Czech license plates #1565
Merged
profnandaa
merged 7 commits into
validatorjs:master
from
filiptronicek:czech-license-plates
Jul 16, 2021
Merged
Add Czech license plates #1565
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c804485
Add Czech license plates to the RegEx mix
filiptronicek c420de2
Reorder list
filiptronicek b57bfb2
Update README
filiptronicek e0decd0
Add tests
filiptronicek 37dc1e8
Merge branch 'master' into czech-license-plates
filiptronicek 6d4b269
Remove trailing space
filiptronicek 2322e06
Add more tests
filiptronicek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: we can increase accuracy in this way.
Passing examples:
This regex does not take into account custom license plates and we have to check it separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shortened version looks way better, I agree @fedeci, but this does not include disallowed characters, which include O, G, Q, and W.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to what I understood from wikipedia, those characters are only disallowed in custom license plates🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think maybe there is conflicting information on the article in English, and the one which is in Czech, this is a paragraph translated from the Czech one:
This means, that this applies to all license plates, not just custom ones.