Skip to content

Chore: refactor code in isDataURI validator #1556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 26, 2021

Conversation

ezkemboi
Copy link
Member

Clean up code in isDataURI validator

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Dec 17, 2020

Codecov Report

Merging #1556 (1486daa) into master (787df19) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1556   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           99       100    +1     
  Lines         1776      1795   +19     
=========================================
+ Hits          1776      1795   +19     
Impacted Files Coverage Δ
src/lib/isDataURI.js 100.00% <100.00%> (ø)
src/index.js 100.00% <0.00%> (ø)
src/lib/isMobilePhone.js 100.00% <0.00%> (ø)
src/lib/isLicensePlate.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 787df19...1486daa. Read the comment docs.

@renanmontebelo
Copy link
Contributor

I believe you should only include src/lib/isDataURI.js because validator.js and validato.min.js are automatically generated by npm test. Also, if you remove these files you would be avoiding/resolving the merge conflict.

@profnandaa profnandaa merged commit b685d55 into validatorjs:master Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants