-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not validate the length of email parts if ignore_max_length is true #1435
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1435 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 95 95
Lines 1254 1254
=========================================
Hits 1254 1254
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
EDIT: it's only skipping the validation for the user part, since we are using isFQDN
internally and it's validating that the fqdn is less than 64 characters.
Thanks @tux-tn - Is there something you would like me to do/change? I don't quite follow you comment. |
@tux-tn -- are there any changes that need to be made as per your comment? |
@profnandaa it depends, Should |
@profnandaa -- maybe we just go with the userpart only, what do you think? @evantahler |
I think so too - the test case I provided is the use case I have... so this meets my needs! |
Thanks! Please let me know when the next version is released! |
Cool; and sorry you just missed the September release train by minutes, so this will be queued up for our next release 20/10. |
This PR skips the special validation of the domain and user if
ignore_max_length
is set to true. The README already implies this behavior is happening:Closes #1434
Checklist