We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug validator.isURL is not compatible when upgrading from 13.6.0 to 13.7.0
Examples const validator = require('validator'); const url = 'http:/some.example.com'; const a = validator.isURL(url.toString(), { protocols: ['http', 'https'], require_tld: false }); console.log(a); // v13.6.0 a is false // v13.7.0 a is true
The text was updated successfully, but these errors were encountered:
Like #1862 this is probably introduced in #1833
Sorry, something went wrong.
Actually, this is not a regression, according to RFC 2396 it's a valid URL. Please check the discussion in #1751 for more information.
I agree this is not a regression, so I believe this issue could be closed.
BTW I find the Wikipedia entry for URL syntax very precise and clear to check for these edge cases: https://en.wikipedia.org/wiki/URL#Syntax
No branches or pull requests
Describe the bug
validator.isURL is not compatible when upgrading from 13.6.0 to 13.7.0
Examples
const validator = require('validator');
const url = 'http:/some.example.com';
const a = validator.isURL(url.toString(), {
protocols: ['http', 'https'],
require_tld: false
});
console.log(a);
// v13.6.0 a is false
// v13.7.0 a is true
The text was updated successfully, but these errors were encountered: