Bump highlight.js from 9.18.1 to 10.1.1 #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps highlight.js from 9.18.1 to 10.1.1 After review of [VERSION_10_UPGRADE.md](https://github.com/highlightjs/highlight.js/blob/master/VERSION_10_UPGRADE.md) and [VERSION_10_BREAKING_CHANGES.md](https://github.com/highlightjs/highlight.js/blob/master/VERSION_10_BREAKING_CHANGES.md), found no incompatibility with markdown-it-highlightjs. Although one of the tests add to be adjusted since v10 no longer outputs surrounding `<span class='php'>...</span>`
…anguage-' Markdown-it has an option called `langPrefix` for the same propose which defaults to `language-`. Default `language-` prefix value follows W3C recommendation. Highlight.js default behavior adds language to class list without any prefix (same as setting `langPrefix = ''` in md options).
|
Thanks a lot! Sorry for the delay :) Released with 3.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps highlight.js from 9.18.1 to 10.1.1
After review of VERSION_10_UPGRADE.md and VERSION_10_BREAKING_CHANGES.md, found no incompatibility with markdown-it-highlightjs.
Although one of the tests add to be adjusted since v10 no longer outputs surrounding
<span class='php'>...</span>