forked from apache/spark
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[SPARK-44866][SQL] Add
SnowflakeDialect
to handle BOOLEAN type corr…
…ectly ### What changes were proposed in this pull request? In Snowflake a BOOLEAN data type exist but not the BIT data type. This PR adds `SnowflakeDialect` to override the default JdbcDialect and redefine the default mapping behaviour for the _boolean_ type. Currently, it's mapped to `BIT(1)` type. https://github.com/apache/spark/blob/a663c0bf0c5b104170c0612f37a0b0cdf75cd45b/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala#L149 ### Why are the changes needed? The BIT type does not exist in Snowflake. This cause the Spark Job to fail on table creation. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Unit test and directly on Snowflake Closes apache#42545 from hayssams/master. Authored-by: Hayssam Saleh <Hayssam.saleh@starlake.ai> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
- Loading branch information
1 parent
a663c0b
commit c8fa821
Showing
3 changed files
with
42 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 changes: 36 additions & 0 deletions
36
sql/core/src/main/scala/org/apache/spark/sql/jdbc/SnowflakeDialect.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one or more | ||
* contributor license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright ownership. | ||
* The ASF licenses this file to You under the Apache License, Version 2.0 | ||
* (the "License"); you may not use this file except in compliance with | ||
* the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.apache.spark.sql.jdbc | ||
|
||
import java.util.Locale | ||
|
||
import org.apache.spark.sql.execution.datasources.jdbc.JdbcUtils | ||
import org.apache.spark.sql.types.{BooleanType, DataType} | ||
|
||
private case object SnowflakeDialect extends JdbcDialect { | ||
override def canHandle(url: String): Boolean = | ||
url.toLowerCase(Locale.ROOT).startsWith("jdbc:snowflake") | ||
|
||
override def getJDBCType(dt: DataType): Option[JdbcType] = dt match { | ||
case BooleanType => | ||
// By default, BOOLEAN is mapped to BIT(1). | ||
// but Snowflake does not have a BIT type. It uses BOOLEAN instead. | ||
Some(JdbcType("BOOLEAN", java.sql.Types.BOOLEAN)) | ||
case _ => JdbcUtils.getCommonJDBCType(dt) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters