Added a test for migrating tables with uuid cols #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YPares
force-pushed
the
test-migration-uuids
branch
from
6770b96 to
00447dc
Compare
exaexa
reviewed
Oct 25, 2025
| newName = mkTableName $ mconcat ["__selda_migration_", rawTableName (tableName t2)] | ||
| renameQuery = mconcat | ||
| [ "ALTER TABLE ", newName | ||
| [ "ALTER TABLE ", fromTableName newName |
There was a problem hiding this comment.
@YPares just curious, is there any reason why taking this through mk&from-TableName is more viable? (sounds same to me so probably OK.)
exaexa
approved these changes
Oct 25, 2025
There was a problem hiding this comment.
@YPares is there any usecase that would be broken by adding this? (I assume not, except for cases where people expect migration from blob to UUID to fail, but that's hardly a breakage right?)
@valderman I guess thsi is OK, any opinions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test that exhibits #180 and provides a quickfix that is probably not great in the postgresql case.