Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poetry + Python 3.10 + Drop 3.6 #60

Merged
merged 11 commits into from
Jan 2, 2023
Merged

Poetry + Python 3.10 + Drop 3.6 #60

merged 11 commits into from
Jan 2, 2023

Conversation

inverse
Copy link
Collaborator

@inverse inverse commented Jul 14, 2022

Proposed change

  • Migrate to poetry
  • Add support for Python 3.10
  • Drop Python 3.6 as it's EOL

How to test the change

Should just work as before just using poetry to manage dependencies.

poetry install
poetry shell
python tell_me_your_secrets/__main__.py 

Checklist

  • Tests have been added to verify that the new code works (if possible)
  • Documentation has been updated to reflect changes
  • Changelog has been updated to reflect changes

@inverse inverse marked this pull request as ready for review July 14, 2022 19:35
@inverse inverse changed the title Migrate to poetry Poetry + Python 3.10 + Drop 3.6 Jul 14, 2022
@inverse inverse requested a review from valayDave July 14, 2022 19:35
@valayDave
Copy link
Owner

Out of curiosity, why are we stopping 3.6 support? I understand that it has reached EOL but I don't think our code has breaking changes that wouldn't work for 3.6. Additionally even though it is EOL there are considerable amounts of downloads for 3.6 which makes me question if we should remove it just yet. What do you think ?

@inverse
Copy link
Collaborator Author

inverse commented Jul 15, 2022

You are correct - there is nothing breaking about these changes however it encourages people to use end of life software which could lead to security issues.

Poetry provides a way to lock dependencies between multiple python versions so that dependencies are consistent. Check the lock file.

Trying to adapt it to be able to resolve the dependencies for Python 3.6 but it's taking a long time :/

[tool.poetry.dependencies]
python = "^3.6.1"
PyYAML = "^6.0"
pandas = "^1.0"
gitignore-parser = "^0.0.8"
single-source = "^0.3.0"

[tool.poetry.dev-dependencies]
pytest = "^6.2.2"
pytest-cov = "^2.11.1"
flake8 = "^3.9.0"
flake8-isort = "^4.1.1"
pre-commit = "^2.11.1"

@valayDave
Copy link
Owner

If it is taking too long then it's totally fine if we don't include it :). PR looks good to me

@inverse
Copy link
Collaborator Author

inverse commented Jul 15, 2022

I know sometimes there are some performance issues with Poetry with these sorts of wide version SAT solving.

e.g. python-poetry/poetry#2094

@inverse inverse merged commit c7abc99 into valayDave:master Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants