Fix contextmenu submenu overflow while preserving expected anchor position#2817
Open
bluegaspode wants to merge 1 commit into
Open
Fix contextmenu submenu overflow while preserving expected anchor position#2817bluegaspode wants to merge 1 commit into
bluegaspode wants to merge 1 commit into
Conversation
…ition - Previously, when a submenu overflowed the viewport bottom, jsTree forced bottom: -1px, which could relocate the submenu far from the hovered item and still allow clipping at the top. - This change switches to overflow-based vertical margin adjustment, improving the chance that the full submenu is visible in constrained vertical space. - The new positioning keeps the submenu as close as possible to where users expect it, instead of snapping to an unrelated bottom-aligned position.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to provide a fix we recently applied to jstree and could improve things also for other users.