Feat: Added Makefile #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaguecoder
reviewed
Jan 5, 2023
Makefile
Outdated
| @@ -0,0 +1,3 @@ | |||
| test: | |||
| @echo "Testing ..." | |||
| @go clean -testcache && go test ./... No newline at end of file | |||
There was a problem hiding this comment.
Git warns about newline. Please add a newline at the end.
There was a problem hiding this comment.
A couple of more changes here. Please add the following flags to go test
-vfor verbosity-racefor data race detection-coverprofile cover.outfor coverage profile
With cover.out, we can get the coverage. Please add this in next line.
go tool cover -func cover.out
Also, go test needn't be hid from stdout. You may keep go clean in @ and take go test command to next line.
tanryberdi
force-pushed
the
tanryberdi.add-makefile
branch
from
91813bd to
b24244c
Compare
Closed
Added Makefile for testing purpose
tanryberdi
force-pushed
the
tanryberdi.add-makefile
branch
from
b24244c to
b0726fa
Compare
|
LGTM. Thanks @tanryberdi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Makefile for testing purpose #2