Feat: Script for Coverage check #22 #38
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanryberdi
force-pushed
the
tanryberdi.issue-22
branch
2 times, most recently
from
0d67d93 to
85401c5
Compare
- Added script for CI for test coverage Signed-off-by: Tanryberdi <tanryberdi@gmail.com> See vaguecoder#22
tanryberdi
force-pushed
the
tanryberdi.issue-22
branch
from
85401c5 to
325efe4
Compare
vaguecoder
reviewed
Feb 11, 2023
| echo "Current test coverage is below threshold. Please add more unit tests or adjust threshold to a lower value." | ||
| echo "Failed" | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
Newline is missing at the end of the file.
There was a problem hiding this comment.
Also, I think sudo is not required. A reference of such tests from etcd here.
|
My initial idea in achieving this is to have a single script that can be called from both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #22