Doc: Fixed typos #16
Merged
Doc: Fixed typos #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanryberdi
commented
Jan 6, 2023
tanryberdi
commented
- Fixed typos
- change ioutil.ReadAll to io.ReadAll
- Fixed Typos and doc corrections #6
tanryberdi
force-pushed
the
tanryberdi.fix-typos
branch
from
34ac2e4 to
82c626f
Compare
|
@vaguecoder could you please take a look to this PR? |
vaguecoder
reviewed
Jan 6, 2023
mux_httpserver_test.go
Outdated
| t.Fatalf("expected a status code of 200, got %v", resp.StatusCode) | ||
| } | ||
| body, err := ioutil.ReadAll(resp.Body) | ||
| body, err := io.ReadAll(resp.Body) |
There was a problem hiding this comment.
ioutil -> io is a valid change but let's not do it here. We can have another issue+PR for the same. Documentation PRs often don't touch the code parts.
There was a problem hiding this comment.
FYI #17 is created for the same
vaguecoder
reviewed
Jan 6, 2023
README.md
Outdated
| * Requests can be matched based on URL host, path, path prefix, schemes, header and query values, HTTP methods or using custom matchers. | ||
| * URL hosts, paths and query values can have variables with an optional regular expression. | ||
| * Registered URLs can be built, or "reversed", which helps maintaining references to resources. | ||
| * Registered URLs can be built, or "reversed", which helps to maintaining references to resources. |
There was a problem hiding this comment.
I believe it should be either to maintain or in maintaining. Please check.
tanryberdi
force-pushed
the
tanryberdi.fix-typos
branch
from
82c626f to
4a37f3d
Compare
|
@vaguecoder please take a look 🙏 |
- Fixed typos Signed-off-by: Tanryberdi <tanryberdi@gmail.com>
tanryberdi
force-pushed
the
tanryberdi.fix-typos
branch
from
4a37f3d to
aee0345
Compare
|
rebased from |
|
Thanks @tanryberdi Good job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.