Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stripping descriptions problem #8

Closed
perdolka opened this issue Nov 30, 2017 · 4 comments
Closed

stripping descriptions problem #8

perdolka opened this issue Nov 30, 2017 · 4 comments

Comments

@perdolka
Copy link
Contributor

1
I thought "stripping descriptions" means something like "deleting descriptions",
but it doesn't occur (in my case).

2
The addon freezes when this cleanup is complete (gray buttons, aren't clicked),
so you need to turn off/on addon - to restore functionality.

my Firefox - 55.0.3 (x64).

@vaeth
Copy link
Owner

vaeth commented Nov 30, 2017

Thanks a lot for the report! This is a serious regression!
It should be fixed now. I will make an emergency release immediately.

@perdolka
Copy link
Contributor Author

Thanks for the quick fix!
Another little problem (or not?) here -
bookmark with cleaned description jumps to 1 position up (in bookmark list Ctrl+B).

@vaeth
Copy link
Owner

vaeth commented Nov 30, 2017

This does not happen here, but I can imagine that this happens if you have "strange" bookmarks in the folder in which you strip the description. (By "strange" I mean things which for some reason are not passed through the bookmark API).
It might also happen if you added a bookmark above the one you strip before you actually do the stripping.

The problem is that this "stripping" is actually not possible by the bookmark API (the bookmark API is not even able to check whether there does exist a description for the bookmark).
This "stripping" is done only with a trick: A new bookmark is created (with the data of the previous bookmark), and the old bookmark is removed. In order to create a new bookmark, it is necessary to specify the parent folder and entry number. The code just gets this parent and number from the bookmark API before displaying the bookmarks and remembers it until you press the button "list all bookmarks" again. So the information might be incorrect (if the bookmark API suppresses certain "special" bookmarks which are then not counted) or outdated (if you added a bookmark between displaying of bookmarks and removal).

@perdolka
Copy link
Contributor Author

OK, thanks for the explanation.

vaeth pushed a commit that referenced this issue Jan 16, 2018
Actualización desde el repositorio padre.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants