Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Empty Folders" option - mistakenly detects rss-folders as empty. #4

Closed
perdolka opened this issue Nov 27, 2017 · 6 comments
Closed

Comments

@perdolka
Copy link
Contributor

No description provided.

@vaeth
Copy link
Owner

vaeth commented Nov 28, 2017

I am afraid that this is a CANTFIX:

The bookmark API
https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/bookmarks/BookmarkTreeNode
does not provide any further information on the type of folders.

Currently, all bookmarks are filtered which according to the API mentioned above

  • contain a uri, or
  • have no parent (to recognize at least "top-level" special type folders), or
  • have some children, or
  • are marked as unmodifiable, or
  • have a type specified which is different from "folder"

I suppose that filtering some "magic names" (which might differ in different languages) is a bad idea.

If you have an idea how this can be properly fixed, please let me know.

@juaalta
Copy link
Contributor

juaalta commented Dec 12, 2017

I do not know if this solves the problem, but it can be a good approximation to use it:
https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/bookmarks/BookmarkTreeNodeType
https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/bookmarks/BookmarkTreeNode
https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/bookmarks

You only need to know if a feed considers it a URL or a folder.

@vaeth
Copy link
Owner

vaeth commented Dec 12, 2017

https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/bookmark/BookmarkTreeNodeType
https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/bookmarks/BookmarkTreeNode

This is already checked: As mentioned, if the type is defined and different from "folder" the bookmark is ignored (for the folder view). Also if any nonempty url is specified, the bookmark is ignored.

https://developer.mozilla.org/en-US/docs/Mozilla/Tech/Places/Using_the_Places_livemark_service

This looks promising, but Components.classes["@mozilla.org/browser/livemark-service;2"] looks like this is about to be obsoleted (and/or special permissions are required to use it). I will check whether the obvious code works.

@vaeth
Copy link
Owner

vaeth commented Dec 12, 2017

No, I won't try:

https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsILivemarkService

shows a big fat: Warning: This interface is obsolete.

If I understand the other bugreports correctly, livemarks will be completely removed eventually (I guess some WebExtensions should be used instead), so perhaps this problem will solve itself with some future firefox versions.

vaeth pushed a commit that referenced this issue Dec 21, 2017
Actualización desde repositorio principal.
@vaeth
Copy link
Owner

vaeth commented Dec 23, 2017

I think everything possible has been done to communicate the problem (which seems unsolvable with the current bookmark API).

Therefore, I am closing this bug for the moment.

@vaeth vaeth closed this as completed Dec 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants