Question: Reusing React?

[mgrip]

Forgive me if this discussion has happened elsewhere already, or if this is not even possible... but I'm curious if its been discussed to make ink basically analogous to ReactDOM, but for interacting with the cli, while being able to reuse React itself for all of the component-based logic?

Curious to hear your thoughts!

p.s. this library is awesome, thank you for your contributions!

[mgrip]

also if this seems remotely plausible, would you be open to a pull request POC'ing this?

[kentrino]

@mgrip
I had thought the same. Theoretically, ink should not mimic React, only should it conform to React's API. I checked MobX (a library that uses React's API) does not get along with ink.
If ink was created based on React and implemented like ReactDOM, it should work with MobX.

But I also think it's really tough to understand React API and how it should be implemented compatible with React (like ReactDOM).
In addition, I guess lifecycles and refresh schemes of browser's DOM and CLI's components are different, so maybe we have to imitate the React's logic.

Any idea?

To author, maintainers

I love this project. Thank you for your contributions!

MobX

https://github.com/mobxjs/mobx

[mgrip]

Ya it would definitely be difficult, but I don’t think impossible. I’m happy to start working on a POC, but I would want to make sure that aligns with the intent of this project - which I think would be a question for @vadimdemedes

[timhudson]

I was thinking about this as well over the weekend. I ran into an issue with getChildContext behaving differently than React. ink could skip the cost of seeking/maintaining parity with React internals by instead being a render path like ReactDOM.

What are the downsides to using React itself?

[mgrip]

I have a small POC working for this just to prove out feasibility - @vadimdemedes let me know if you think this is a direction that would make sense for this project, otherwise I can spin it off into a different one.

[vadimdemedes]

Hey @mgrip, sorry for late reply, but yes, I would definitely be interested in reusing React! If you could send the link to a repo with a POC, it would be awesome!

[mgrip]

No worries! Sorry I wanted to use this as a dependency for a different project I was working on, so I built it already as a new project 😕 https://github.com/mgrip/react-cli

[vadimdemedes]

@mgrip That's great! Thank you for sharing, I will start experimenting with your reconciler and see what happens :)

[vadimdemedes]

Feels good to close this issue :) Ink 2 uses React!

[mgrip]

Looks awesome, thanks @vadimdemedes!