This repository has been archived by the owner on Jun 14, 2024. It is now read-only.
transport protocol specification #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rshiv <reeshav96@gmail.com>
jm-clius
suggested changes
Nov 9, 2021
Co-authored-by: Hanno Cornelius <68783915+jm-clius@users.noreply.github.com>
oskarth
reviewed
Nov 10, 2021
Signed-off-by: rshiv <reeshav96@gmail.com>
staheri14
reviewed
Nov 12, 2021
staheri14
reviewed
Nov 12, 2021
oskarth
reviewed
Nov 12, 2021
jm-clius
suggested changes
Nov 12, 2021
There was a problem hiding this comment.
Some comments on clarity. In general one idea per sentence may be easier to understand (e.g. having a single sentence explain that we can support both secure and unsecure websockets and the context in which they may be used may become ambiguous/difficult to parse).
Signed-off-by: rshiv <reeshav96@gmail.com>
Signed-off-by: rshiv <reeshav96@gmail.com>
oskarth
reviewed
Nov 16, 2021
oskarth
approved these changes
Nov 16, 2021
Co-authored-by: oskarth <ot@oskarthoren.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: rshiv reeshav96@gmail.com