Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(flaky): Increase check timeouts #995

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Conversation

AlejandroCabeza
Copy link
Collaborator

@AlejandroCabeza AlejandroCabeza commented Nov 30, 2023

Description

Attempt to fix flaky tests by increasing the check timeout.

Changes

  • Increase check timeouts.

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9468bb6) 83.17% compared to head (e3c96dc) 83.15%.
Report is 2 commits behind head on unstable.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           unstable     #995      +/-   ##
============================================
- Coverage     83.17%   83.15%   -0.02%     
============================================
  Files            91       91              
  Lines         15342    15344       +2     
============================================
- Hits          12760    12759       -1     
- Misses         2582     2585       +3     

see 6 files with indirect coverage changes

@diegomrsantos diegomrsantos marked this pull request as draft December 5, 2023 16:30
@AlejandroCabeza AlejandroCabeza marked this pull request as ready for review January 26, 2024 10:29
kaiserd
kaiserd previously approved these changes Jan 26, 2024
Copy link
Collaborator

@kaiserd kaiserd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlejandroCabeza AlejandroCabeza force-pushed the flaky-fixes branch 2 times, most recently from 4a34028 to 1f12086 Compare January 26, 2024 16:36
@AlejandroCabeza AlejandroCabeza changed the title tests(flaky): Fix tests(flaky): Increase check timeouts Jan 26, 2024
@AlejandroCabeza AlejandroCabeza enabled auto-merge (squash) January 31, 2024 23:05
@AlejandroCabeza AlejandroCabeza merged commit 9bc5ec1 into unstable Jan 31, 2024
11 of 18 checks passed
@AlejandroCabeza AlejandroCabeza deleted the flaky-fixes branch January 31, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: done
Development

Successfully merging this pull request may close these issues.

3 participants