fix(dcutr): handle tcp/p2p addresses #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accepts /ip4/198.51.100/tcp/1234/p2p/QmYyQSo1c1Ym7orWxLYvCrM2EmxFTANf8wXmmE7DWjhx5N as a dialable tcp address
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #989 +/- ##
============================================
+ Coverage 83.15% 83.19% +0.04%
============================================
Files 91 91
Lines 15306 15317 +11
============================================
+ Hits 12727 12743 +16
+ Misses 2579 2574 -5
|
lchenut
approved these changes
Nov 20, 2023
romanzac
pushed a commit
that referenced
this pull request
Nov 30, 2023
dryajov
pushed a commit
that referenced
this pull request
Dec 4, 2023
romanzac
pushed a commit
that referenced
this pull request
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accepts addresses like /ip4/198.51.100/tcp/1234/p2p/QmYyQSo1c1Ym7orWxLYvCrM2EmxFTANf8wXmmE7DWjhx5N as a dialable tcp address