Rate Limit tests #953
Merged
Rate Limit tests #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## unstable #953 +/- ##
============================================
+ Coverage 83.04% 83.21% +0.17%
============================================
Files 91 91
Lines 15308 15308
============================================
+ Hits 12712 12739 +27
+ Misses 2596 2569 -27 |
diegomrsantos
force-pushed
the
traffic-score-tests
branch
2 times, most recently
from
e6efbba
to
f9b67f8
Compare
Menduist
reviewed
Oct 4, 2023
tests/pubsub/testgossipsub.nim
Outdated
| await gossip0.peers[gossip1.switch.peerInfo.peerId].sendEncoded(newSeqWith[byte](30, 1.byte)) | ||
| await sleepAsync(300.millis) | ||
|
|
||
| check getCurrentDisconnections() == disconnections + 1 |
There was a problem hiding this comment.
Once this actually disconnects, we should check here that we are no longer connected
Can you add a TODO?
Otherwise, LGTM
There was a problem hiding this comment.
Did this and other minor improvements.
Menduist
previously approved these changes
Oct 4, 2023
diegomrsantos
force-pushed
the
traffic-score-tests
branch
2 times, most recently
from
d1becbf
to
06dca09
Compare
diegomrsantos
force-pushed
the
traffic-score-tests
branch
from
06dca09
to
6d453c4
Compare
Menduist
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.