chore: add basic metrics for rendezvous #905
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we have enabled Rendezvous Discovery in nwaku by default (as long as relay is enabled), we need to be able to measure some basic usage.
This is my attempt to add basic set of metrics:
libp2p_rendezvous_register
- counter for register/advertise requestslibp2p_rendezvous_discover
- counter for discover/request requestslibp2p_rendezvous_registered
- gauge representing number of currently registered peerslibp2p_rendezvous_namespaces
- gauge representing number of currently known namespacesI am not sure if my approach to setting these metrics is optimal, so would love any suggestions for improvements