Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try a direct connection only if there isn't one already #891

Merged
merged 4 commits into from
May 25, 2023

Conversation

diegomrsantos
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #891 (98ebb89) into unstable (7d6bc54) will increase coverage by 0.04%.
The diff coverage is 92.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           unstable     #891      +/-   ##
============================================
+ Coverage     84.25%   84.30%   +0.04%     
============================================
  Files            91       91              
  Lines         15332    15345      +13     
============================================
+ Hits          12918    12936      +18     
+ Misses         2414     2409       -5     
Impacted Files Coverage Δ
libp2p/services/hpservice.nim 89.77% <92.00%> (+2.93%) ⬆️

... and 23 files with indirect coverage changes

Menduist
Menduist previously approved these changes May 24, 2023
Copy link
Contributor

@Menduist Menduist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides style questions

@diegomrsantos diegomrsantos merged commit a677b06 into unstable May 25, 2023
@diegomrsantos diegomrsantos deleted the direct-conn-fix branch May 25, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants