GossipSub: remove peer if we can't establish sendConn #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #886 +/- ##
============================================
- Coverage 84.28% 84.27% -0.01%
============================================
Files 91 91
Lines 15322 15323 +1
============================================
Hits 12914 12914
- Misses 2408 2409 +1
|
|
how about tests? |
|
This PR is very hard to test because it only happens with buggy clients |
diegomrsantos
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if we can't establish a sendConn, we will swallow messages, which can lead to asymmetric mesh and useless memory usage
This PR changes the behavior to consider the peer disconnected if we can't establish a sendConn in 5 seconds