Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not allow an empty MA #877

Merged
merged 3 commits into from
Apr 6, 2023
Merged

Does not allow an empty MA #877

merged 3 commits into from
Apr 6, 2023

Conversation

diegomrsantos
Copy link
Collaborator

@diegomrsantos diegomrsantos commented Mar 22, 2023

MutliAddress spec doesn't allow an empty address.

Human-readable multiaddr: (/<protoName string>/<value string>)+
Example: /ip4/127.0.0.1/udp/1234
Machine-readable multiaddr: (<protoCode uvarint><value []byte>)+
Same example: 0x4 0x7f 0x0 0x0 0x1 0x91 0x2 0x4 0xd2
Values are usually length-prefixed with a uvarint

Menduist
Menduist previously approved these changes Mar 22, 2023
@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #877 (13c7975) into unstable (4aa615c) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           unstable     #877      +/-   ##
============================================
+ Coverage     84.16%   84.23%   +0.07%     
============================================
  Files            87       87              
  Lines         15109    15119      +10     
============================================
+ Hits          12717    12736      +19     
+ Misses         2392     2383       -9     
Impacted Files Coverage Δ
libp2p/stream/chronosstream.nim 76.28% <ø> (ø)
libp2p/multiaddress.nim 86.40% <100.00%> (+0.90%) ⬆️

... and 5 files with indirect coverage changes

@Menduist
Copy link
Contributor

Just linking discussions here: multiformats/rust-multiaddr#85

Menduist
Menduist previously approved these changes Apr 3, 2023
@diegomrsantos diegomrsantos enabled auto-merge (squash) April 6, 2023 13:20
@diegomrsantos diegomrsantos merged commit 80cca0e into unstable Apr 6, 2023
@diegomrsantos diegomrsantos deleted the not-empty-ma branch April 6, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants