Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix network protocol metrics typo #874

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Fix network protocol metrics typo #874

merged 1 commit into from
Apr 26, 2023

Conversation

Menduist
Copy link
Contributor

@Menduist Menduist commented Mar 8, 2023

That's what you gain by not using typed things

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #874 (086a4c3) into unstable (8d5ea43) will decrease coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           unstable     #874      +/-   ##
============================================
- Coverage     83.83%   83.80%   -0.04%     
============================================
  Files            86       86              
  Lines         14969    14970       +1     
============================================
- Hits          12550    12546       -4     
- Misses         2419     2424       +5     
Impacted Files Coverage Δ
libp2p/muxers/mplex/lpchannel.nim 83.13% <ø> (+0.09%) ⬆️
libp2p/protocols/secure/secure.nim 71.15% <0.00%> (-3.85%) ⬇️
libp2p/muxers/mplex/mplex.nim 87.70% <0.00%> (-0.82%) ⬇️
libp2p/transports/wstransport.nim 85.71% <0.00%> (ø)

@Menduist Menduist marked this pull request as ready for review April 26, 2023 07:51
@Menduist Menduist merged commit db629dc into unstable Apr 26, 2023
@Menduist Menduist deleted the fixtypo branch April 26, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant