Create an ObservedAddrManager and add an AddressMapper in AutonatService and AutoRelayService #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: diegomrsantos <diego@status.im>
# Conflicts: # libp2p/connmanager.nim # libp2p/protocols/connectivity/autonat/service.nim # tests/testconnmngr.nim
diegomrsantos
force-pushed
the
observed-addr-manager
branch
from
88f3ae2
to
4fc7b6d
Compare
Menduist
reviewed
Mar 8, 2023
# Conflicts: # libp2p/peerstore.nim
diegomrsantos
force-pushed
the
observed-addr-manager
branch
from
5d1b04a
to
7cb27cc
Compare
Closed
diegomrsantos
force-pushed
the
observed-addr-manager
branch
from
73a46a1
to
f4b34f2
Compare
Menduist
reviewed
Mar 22, 2023
| let observedAddrManager = ObservedAddrManager.new(minCount = 3) | ||
|
|
||
| # Calculate the most oberserved IP4 correctly | ||
| let mostObservedIP4AndPort = MultiAddress.init("/ip4/1.2.3.0/tcp/1").get() |
There was a problem hiding this comment.
Can you test with invalid multiaddresses, seems like it will crash
Menduist
reviewed
Mar 22, 2023
libp2p/peerstore.nim
Outdated
| ## Returns the most observed IP address or none if the number of observations are less than minCount. | ||
| return self.identify.getMostObservedIP(ipVersion) | ||
|
|
||
| proc replaceMAIpByMostObserved*( |
There was a problem hiding this comment.
It is used by guessDialableAddrs which is used in hpservice and the dcutr server.
There was a problem hiding this comment.
Sure, but this is unrelated to the peer store
There was a problem hiding this comment.
Where would you add it? I think it is related to the observed addresses.
Menduist
reviewed
Mar 22, 2023
diegomrsantos
changed the title
Menduist
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ObservedAddrManagerwhich keeps track of the most observed addresses reported by remote peers.AddressMapperinAutonatServicewhich tries to identify the peer public IP/Port when there's a manual port forward configured.AddressMapperinAutonRelayServicewhich adds the relayed address.