Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add anyCompleted proc #853

Merged
merged 2 commits into from
Feb 7, 2023
Merged

Add anyCompleted proc #853

merged 2 commits into from
Feb 7, 2023

Conversation

diegomrsantos
Copy link
Collaborator

No description provided.

@dryajov
Copy link
Contributor

dryajov commented Feb 7, 2023

Seems like you're duplicating this - https://github.com/status-im/nim-chronos/blob/master/chronos/asyncfutures2.nim#L993 - the usual nomenclature in the async world for return on first completed fut is race.

@diegomrsantos
Copy link
Collaborator Author

diegomrsantos commented Feb 7, 2023

Seems like you're duplicating this - https://github.com/status-im/nim-chronos/blob/master/chronos/asyncfutures2.nim#L993 - the usual nomenclature in the async world for return on first completed fut is race.

I use race to return the first future that completes or a failed one if none completes.

@dryajov
Copy link
Contributor

dryajov commented Feb 7, 2023

Seems like you're duplicating this - https://github.com/status-im/nim-chronos/blob/master/chronos/asyncfutures2.nim#L993 - the usual nomenclature in the async world for return on first completed fut is race.

I use race to return the first future that completes or a failed one if none completes.

Right, thats how you'd use it, how do you intend to use this one?

@diegomrsantos
Copy link
Collaborator Author

Seems like you're duplicating this - https://github.com/status-im/nim-chronos/blob/master/chronos/asyncfutures2.nim#L993 - the usual nomenclature in the async world for return on first completed fut is race.

I use race to return the first future that completes or a failed one if none completes.

Right, thats how you'd use it, how do you intend to use this one?

It is coming in the next PR.

@diegomrsantos diegomrsantos merged commit 266c7b1 into unstable Feb 7, 2023
@diegomrsantos diegomrsantos deleted the any-completed branch February 7, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants