Add expected connections to connmngr #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #845 +/- ##
============================================
+ Coverage 83.73% 83.74% +0.01%
============================================
Files 85 85
Lines 15023 15047 +24
============================================
+ Hits 12579 12601 +22
- Misses 2444 2446 +2
|
Menduist
commented
Jan 23, 2023
Co-authored-by: diegomrsantos <diego@status.im>
diegomrsantos
force-pushed
the
expectconnection
branch
from
d26222c
to
2b05f49
Compare
diegomrsantos
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This system allows you to wait for a connection from a specific peer. It will bypass the
maxConnectionsPerPeer, since you know you are waiting for him (but not the global limit of connections)This is useful for AutoNat, HolePunching, maybe others
Also.. turns out the maxConnectionsPerPeer was off by one (hurray). I fixed it here, but maybe we should leave it as is to avoid changing the behavior. idk
EDIT: reverted, breaks to many things