-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Less warnings #813
Merged
Merged
Less warnings #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegomrsantos
force-pushed
the
lesswarnings2
branch
from
April 24, 2023 12:38
080d11b
to
f578489
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #813 +/- ##
============================================
+ Coverage 84.28% 84.31% +0.03%
============================================
Files 91 91
Lines 15322 15325 +3
============================================
+ Hits 12914 12922 +8
+ Misses 2408 2403 -5
|
diegomrsantos
force-pushed
the
lesswarnings2
branch
from
April 25, 2023 11:28
e412a65
to
005c326
Compare
Menduist
commented
Apr 26, 2023
Menduist
commented
Apr 26, 2023
Menduist
commented
Apr 26, 2023
see also: nim-lang/Nim#21728 |
Menduist
commented
Apr 26, 2023
Menduist
commented
Apr 26, 2023
Menduist
commented
May 5, 2023
Menduist
commented
May 5, 2023
Menduist
commented
May 5, 2023
Menduist
commented
May 5, 2023
Menduist
commented
May 5, 2023
lchenut
reviewed
May 10, 2023
lchenut
reviewed
May 10, 2023
diegomrsantos
force-pushed
the
lesswarnings2
branch
from
May 16, 2023 10:07
4668f65
to
72a53f3
Compare
Menduist
commented
May 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
lchenut
approved these changes
May 16, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also see status-im/nim-chronos#332