-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade flow refactoring #807
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dryajov
reviewed
Nov 23, 2022
dryajov
reviewed
Nov 23, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #807 +/- ##
============================================
- Coverage 83.88% 83.77% -0.12%
============================================
Files 86 86
Lines 15096 14969 -127
============================================
- Hits 12663 12540 -123
+ Misses 2433 2429 -4
|
Menduist
force-pushed
the
upgraderefacto
branch
from
January 2, 2023 16:04
b7ff794
to
6992d81
Compare
Closed
Co-authored-by: diegomrsantos <diego@status.im>
# Conflicts: # libp2p/connmanager.nim # libp2p/protocols/connectivity/autonat/service.nim # tests/testconnmngr.nim
This PR is now stable on nimbus, anything else to change? |
diegomrsantos
approved these changes
Mar 6, 2023
lchenut
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies a lot the upgrade flow
The main thing is that
upgradeIncoming
andupgradeOutgoing
now return theMuxer
, that the switch / dialer will then pass to the connManager to be stored.Previously, this relied on the upgrade manager storing the connection itself at the end of the process
Other things:
Sorry, big PR, but one thing lead to another