Rework dial and accept to return Session
#565
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dryajov
force-pushed
the
unstable
branch
2 times, most recently
from
39645a8
to
5419784
Compare
markspanbroek
force-pushed
the
transport-session
branch
from
d1b74b9
to
f966933
Compare
Closed
markspanbroek
force-pushed
the
transport-session
branch
from
f966933
to
50d3b27
Compare
markspanbroek
force-pushed
the
transport-session
branch
from
50d3b27
to
fa27f55
Compare
dryajov
reviewed
Jun 22, 2021
markspanbroek
force-pushed
the
transport-session
branch
from
fa27f55
to
08e9f5c
Compare
|
I've updated this on the latest unstable, though we should maybe hold off on this for a little while, until we have a better overview of the conn manager |
|
Latest commit adds direction parameter to Session.getStream(), so that I can support both outgoing and incoming streams in Quic. |
markspanbroek
force-pushed
the
transport-session
branch
2 times, most recently
from
44bb234
to
9d23e09
Compare
Also adds list of Sessions to TcpTransport, which will replace clients list eventually.
Also adds list of Sessions to WsTransport, which will replace clients list eventually.
These have been replaced by sessions and sessionHandler.
This error code indicates that server socket is already closed, so we raise a TransportClosedError. Fixes CI failure in Windows.
Quic allows opening outgoing or accepting incoming streams.
markspanbroek
force-pushed
the
transport-session
branch
from
9d23e09
to
0c5b832
Compare
|
Closed in favor of #725 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
Transport.dial()andTransport.accept()to return aSessioninstead of aConnection. AConnectioncan be obtained by callinggetStream()on theSessionobject.This is in preparation for integration of QUIC (#563). In QUIC opening a connection and opening a stream are separate operations.