Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: setting dialing canceled log to trace #1153

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

gabrielmer
Copy link
Contributor

@gabrielmer gabrielmer commented Jul 17, 2024

We are trying to reduce the logs load in our fleets, and one of the most recurrent one is

Dialing canceled                           topics="libp2p dialer" tid=1 file=dialer.nim:67 err="Future operation cancelled!" peerId=16U*XAFJX3

which is quite spammy and doesn't give much info.

In addition to that, its corresponding Dialing address log is in trace.

So adjusting the log level of Dialing canceled to trace :)

@diegomrsantos diegomrsantos changed the title setting dialing canceled log to trace chore: setting dialing canceled log to trace Jul 17, 2024
@gabrielmer gabrielmer enabled auto-merge (squash) July 23, 2024 08:47
@gabrielmer gabrielmer disabled auto-merge July 23, 2024 08:47
@jakubgs
Copy link

jakubgs commented Jul 23, 2024

Can this be merged?

@gabrielmer
Copy link
Contributor Author

I'm not being able to merge it because of the failing CI (which is not related to the PR).

@AlejandroCabeza is there any way to merge it?

@diegomrsantos diegomrsantos merged commit f8d4da6 into master Jul 23, 2024
11 of 12 checks passed
@diegomrsantos diegomrsantos deleted the chore-changing-log-level-to-dial-canceled-log branch July 23, 2024 12:14
@diegomrsantos
Copy link
Collaborator

diegomrsantos commented Jul 23, 2024

@kaiserd I temporarily marked the "transport interoperability tests" job as non-required as it's been broken for some time and preventing PRs from being merged, but it needs to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: done
Development

Successfully merging this pull request may close these issues.

5 participants